knightcrawler-stremio / knightcrawler

A selfhosted Stremio addon
Apache License 2.0
265 stars 38 forks source link

Critical bug: Consumer didn't build correctly/won't start #88

Closed purple-emily closed 7 months ago

purple-emily commented 7 months ago

The GitHub action has built the new consumer, but it will not start up.

consumer-1  | node:internal/modules/cjs/loader:1147
consumer-1  |   throw err;
consumer-1  |   ^
consumer-1  | 
consumer-1  | Error: Cannot find module '/app/dist/index.cjs'
consumer-1  |     at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15)
consumer-1  |     at Module._load (node:internal/modules/cjs/loader:985:27)
consumer-1  |     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12)
consumer-1  |     at node:internal/main/run_main_module:28:49 {
consumer-1  |   code: 'MODULE_NOT_FOUND',
consumer-1  |   requireStack: []
consumer-1  | }
consumer-1  | 
consumer-1  | Node.js v20.11.1
consumer-1 exited with code 0

Using current code base:

  consumer:
    image: gabisonfire/knightcrawler-consumer:latest
    env_file:
      - .env
    deploy:
      replicas: ${CONSUMER_REPLICAS}
    <<: *knightcrawler-app
    networks:
      - knightcrawler-network
      - postgres-access
purple-emily commented 7 months ago

@sleeyax any input from you would be good too :)

purple-emily commented 7 months ago

I'm going to roll back the tag.

If you want to see the bug in action then you need to use the image: sha-befd929

docker pull gabisonfire/knightcrawler-consumer:sha-befd929

  consumer:
    image: gabisonfire/knightcrawler-consumer:sha-befd929
    env_file:
      - .env
    deploy:
      replicas: ${CONSUMER_REPLICAS}
    <<: *knightcrawler-app
    networks:
      - knightcrawler-network
      - postgres-access
sleeyax commented 7 months ago

Easy, it should be dist/main.cjs instead. I can create a PR.

sleeyax commented 7 months ago

Easy, it should be dist/main.cjs instead. I can create a PR.

ok never mind lol

iPromKnight commented 7 months ago

was just in the process of creating ^^ Lol