search

knightcrawler25 / GLSL-PathTracer

A toy physically based GPU path tracer (C++/OpenGL/GLSL)
MIT License
1.87k stars 176 forks source link

Scene list does not work in release mode #50

Closed pcarret closed 3 years ago

pcarret commented 3 years ago

Hello,

The scene list looks ok in Debug mode but is filled only by first .scene file in Release Configuration

Thanks for this amazing work Philippe

knightcrawler25 commented 3 years ago

I'm unable to reproduce this. Will you be able to try compiling with a different platform toolset?

image

erfan-khadem commented 3 years ago

Hello,

The scene list looks ok in Debug mode but is filled only by first .scene file in Release Configuration

Thanks for this amazing work Philippe

Couldn't reproduce this with cmake on linux (GCC 11.1) Can you provide a screenshot or add a few lines around here to print scenes.data()?

pcarret commented 3 years ago

You are right it works with vc141 Release mode and it fails with vc142 Release mode . So it's maybe a bug in UI library itself

Le sam. 9 oct. 2021 à 01:47, Asif @.***> a écrit :

I'm unable to reproduce this. Will you be able to try compiling with a different platform toolset?

[image: image] https://user-images.githubusercontent.com/11459803/136635729-952926fa-e1f7-4b94-8710-5c9285332b6f.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/knightcrawler25/GLSL-PathTracer/issues/50#issuecomment-939181466, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWV5C7EACFTE6N5NFRTHGTUF57JBANCNFSM5FUKXKSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

knightcrawler25 commented 3 years ago

I'm not really familiar with imgui code but it looks like some sort of compiler + imgui incompatibility. Since it happens only in Release mode, could you also try disabling optimization while on v142 toolset and see if that makes any difference? Also what version of VS are you on? 16.11.4?

image

pcarret commented 3 years ago

You are right 👍