search

knightcrawler25 / GLSL-PathTracer

A toy physically based GPU path tracer (C++/OpenGL/GLSL)
MIT License
1.87k stars 176 forks source link

Added some command line options #51

Closed erfan-khadem closed 2 years ago

erfan-khadem commented 3 years ago

Here is the list of options I have added. I will write a help or usage message soon. If you would like to have the names changed or other options, I will add them too.

--end-after : Save and exit after rendering the n-th frame --fix-resolution : Force the window resolution to be the number specified in the .scene file --output-name-prefix : Prefix the output file name with the specified string --denoise-frame-count : Use OIDN every n-th frame

tigrazone commented 3 years ago

--end-after and --output-name-prefix done in my fork of renderer. --output-name-prefix named -o --end-after named -spp for fixed samples amount, save file and exit, -time for render some time, save file and exit. https://github.com/tigrazone/GLSL-PathTracer/ Now in 2-3 days I refactor render - I find errors in my disney brdf implementation and recreate renderer based on last original repo code

tigrazone commented 3 years ago

I do update of my repo with needed features. Use if you want

erfan-khadem commented 3 years ago

--end-after and --output-name-prefix done in my fork of renderer. --output-name-prefix named -o --end-after named -spp for fixed samples amount, save file and exit, -time for render some time, save file and exit. https://github.com/tigrazone/GLSL-PathTracer/ Now in 2-3 days I refactor render - I find errors in my disney brdf implementation and recreate renderer based on last original repo code

Awesome! Will you add the --fix-resolution too? It would be good to add an option to disable rotation/pan/zoom with mouse too. Also, which other features are you working on? I want to spend some time on this project too, so I don't want to duplicate work again. Also I will close this PR after your next comment.

tigrazone commented 3 years ago

--fix-resolution dont want to do. use scene file settings

erfan-khadem commented 3 years ago

--fix-resolution dont want to do. use scene file settings

There is a problem with that. If the specified resolution is higher than that of display, the window gets auto-resized to fit, and that would cause the render resolution to change too. As a proof that this happens to other people too, check the Mustang_Red.jpg screenshot. It has a rather weird resolution of 1920x1017. I really doubt someone intentionally chose this resolution. Please, let me know if I am wrong or there is another workaround.