knightlab-analyses / regression-benchmarking

BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Can we make the grids in `ParameterGrids` class variables? #16

Closed gwarmstrong closed 4 years ago

gwarmstrong commented 4 years ago

These grids (for example) are defined as variables within class methods: https://github.com/knightlab-analyses/regression-benchmarking/blob/808a6d00523922499ec5e67883828e2a1e0d1796/q2_mlab/_parameters.py#L77-L100

It would be really nice if they were defined as class variables so the grids could be grabbed from elsewhere. An example use case would be if you wanted to check whether there was a parameter grid for a given algorithm. You could not do that with the current approach unless you redefined that grids variable.