search

knights-of-academia / horace

discord.js bot powering the Knights of Academia server with commands like info, AFK, and more
MIT License
23 stars 19 forks source link

[BUG REPORT] storagedata.db should be added to .gitignore #122

Closed Zaph-x closed 4 years ago

Zaph-x commented 4 years ago

Disclaimer I didn't feel this was a feature request, but it doesn't seem like a bug report either. More like a general issue.

Please Describe Your Issue Currently the storagedata test database is commited with everything else. This is not optimal, as it is being updated by every user testing a feature in development

How to Reproduce Pull repository

Expected behavior storagedata.db is in the root directory of Horace, as well as storagedatas.db.

I cut the rest off as it was not relevant for this issue

Dendrobyte commented 4 years ago

done for tomorrow’s highlight pr

Le mer. 29 janv. 2020 à 22:31, Zaph notifications@github.com a écrit :

Disclaimer I didn't feel this was a feature request, but it doesn't seem like a bug report either. More like a general issue.

Please Describe Your Issue Currently the storagedata test database is commited with everything else. This is not optimal, as it is being updated by every user testing a feature in development

How to Reproduce Pull repository

Expected behavior storagedata.db is in the root directory of Horace, as well as storagedatas.db.

I cut the rest off as it was not relevant for this issue

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Knights-Of-Academia/horace/issues/122?email_source=notifications&email_token=ADATWBU2XCY6F4HUHKQKICLRAHYUZA5CNFSM4KNL2LBKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IJVDDBA, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADATWBQDTFYSYMPHFGQHIM3RAHYUZANCNFSM4KNL2LBA .

-- Mark Bacon NYU '22 B.A. Psychology B.A. Language and Mind

ghost commented 4 years ago

Are we planning on moving clan data (and basically anything else in /data) to the new Sequelize system? If so, then we should plan on keeping one copy of the DB with that data in once that's done.

P.S. Adding a comment is gonna bump this but this can be closed I think, it looks like everything was merged.