Few missing features - Githubissues

knightss27 / grafana-network-weathermap

A fully featured and customizable network weathermap plugin for Grafana (9.0+).

https://grafana.com/grafana/plugins/knightss27-weathermap-panel/

Apache License 2.0

139 stars 7 forks source link

Few missing features #11

Open nitzan-tz opened 2 years ago

nitzan-tz commented 2 years ago

First thank you for this plugin

I am missing few features from the original Weathermap

Popup of the graph in "Dashboard Link" like OVERLIBGRAPH in the original Weathermap
Link names that appear alongside the link like INCOMMENT/OUTCOMMENT in the original Weathermap

Other then that if you can increase the text box size for the numbers beside the bar based options like "Arrow Width" for example as it show only single digit so above 10 you don't see the number (I am using Chrome)

knightss27 commented 2 years ago

Glad you are using it!

I have been trying to decide the best way to add the graphs on hover. I would love to allow linking another graph from your dashboard, which would just pop up, but I have yet to get that working. I may end up just adding a simple line graph showing the past X hours/minutes of data.
This should be possible, I will add it to my TODO list.

And I'll look into that text box issue, it is probably mine or Grafana's CSS.

knightss27 commented 2 years ago

Just wanted to add an update on this issue, specifically the popup graph. I have been working towards this for a while, and recently found the proper way to incorporate Grafana's own TimeSeries component, unfortunately for me there is essentially no documentation on how to use this component (so adding the customization I'd like to have has been a real pain so far). I've added a little peak of the basics though.

engenharia-imediadata commented 1 year ago

Hi! Thanks @knightss27 for the awesome job. I've started to migrate from my old cacti with weathermap to this new plugin you've been working well.

Please is possible can you consider to put both part of the link in the same popup and with a little description or maybe a query with the device and port where the info was collected. Looking like this ipotetic graph below.

knightss27 commented 1 year ago

Graphs will be released with the next update, hopefully released during the coming week. You can see a sneak peek of the current implementation below. Please let me know if there's anything you would like adding.

knightss27 commented 1 year ago

Graphs are live on Grafana! Let me know if there are any bugs.

Andreag00 commented 1 year ago

Graphs are live on Grafana! Let me know if there are any bugs.

I've just updated. Graphs work for the links whose data comes from Telegraf+InfluxDB, while they show as empty for the link whose data comes from Prometheus.

Data coming from InfluxDB+Telegraf Data coming from Prometheus:

The problem is not the scale, as other graphs with the same limit at 954Mib/s and low traffic at least show a yellow line when data comes from InfluxDB, meaning data is coming in and being processed.

If you need further information or any debug info I can gladly get them and post them if you let me know where I could find it

knightss27 commented 1 year ago

This is surprising as I usually only test queries with Prometheus as it's the datasource I have in my Docker testing environment (where I can confirm the graph works), so this shouldn't be a Prometheus specific problem. Would you mind going to the panel, and at the top instead of clicking edit click "Inspect" > "Panel JSON" and then on the dropdown at the top of the new window choose "DataFrame JSON", and then take what's there and post it here? Feel free to edit names or concatenate the large chunks of actual data as you want (or just attach a big JSON file).

Andreag00 commented 1 year ago

This is surprising as I usually only test queries with Prometheus as it's the datasource I have in my Docker testing environment (where I can confirm the graph works), so this shouldn't be a Prometheus specific problem. Would you mind going to the panel, and at the top instead of clicking edit click "Inspect" > "Panel JSON" and then on the dropdown at the top of the new window choose "DataFrame JSON", and then take what's there and post it here? Feel free to edit names or concatenate the large chunks of actual data as you want (or just attach a big JSON file).

Here is the JSON file. It was way too long to just copy-paste it here. Had to zip it cause GitHub wouldn't let me attach the JSON file directly. panel.zip

EDIT: Found the issue, Prometheus query have to be set as "Range" and not "Instant" queries. Changed all the queries to "Range" and graphs work now. :)

knightss27 commented 1 year ago

EDIT: Found the issue, Prometheus query have to be set as "Range" and not "Instant" queries. Changed all the queries to "Range" and graphs work now. :)

Ah makes sense! I think the documentation page had previously suggested this, but now that I'm actually using the other data for graphs, I've updated the docs to not suggest instant queries. Thanks for pointing this out though!