knightss27 / grafana-network-weathermap

A fully featured and customizable network weathermap plugin for Grafana (9.0+).
https://grafana.com/grafana/plugins/knightss27-weathermap-panel/
Apache License 2.0
139 stars 7 forks source link

Names with Prometheus should be Grafana's #30

Closed eyalzo closed 1 year ago

eyalzo commented 1 year ago

Describe the problem When fetching data from Prometheus, the names are taken directly from Prometheus, showing only the labels. I'm using 0.3.2 (manual installation). With version 0.3.1 I couldn't use bandwidth queries at all (it displayed just "No Label").

To Reproduce Steps to reproduce the behavior (if possible): Use a Prometheus server.

Expected behavior It would better use Grafana's naming system, meaning the series name (A,B etc) or Grafana's labeling system for Prometheus (as performed by Duagram plugin for example).

Screenshots The first query (out of two), that has a unique legend name and a unique series name:

image

How the two queries appear in the plugin's select box:

image

VERSIONS! (please complete the following information):

knightss27 commented 1 year ago

Ugh, this should work but actually thanks so much for pointing me to the Duagram plugin since it turns out Grafana actually has a function for this stuff. I will quickly push a new version today to Github that hopefully fixes this once and for all.

knightss27 commented 1 year ago

Fixed with v0.3.3. I've submitted it for Grafana's review, so should be live sometime this week (skipping v0.3.2 for Grafana's own site).

eyalzo commented 1 year ago

It's working! Version 0.3.3. Thanks a lot.

image
eyalzo commented 1 year ago

It should be noted that there is still a minor bug there (?)- seems like it's impossible to delete the query, meaning to say something like "I regret and would like to leave this field empty". I think there should be an X for that. See for example the X here in the Node's status (it doesn't reset that field either, btw):

image
knightss27 commented 1 year ago

Good catch, I need to add a clearing option for the other fields. I'll make sure this gets in the next update.