search

knightss27 / grafana-network-weathermap

A fully featured and customizable network weathermap plugin for Grafana (9.0+).
https://grafana.com/grafana/plugins/knightss27-weathermap-panel/
Apache License 2.0
132 stars 6 forks source link

Current speed value's in dashboard config #61

Closed EYEVO closed 1 year ago

EYEVO commented 1 year ago

Currently, every time I exit I get asked to save the dashboard even tho I have not changed anything. When I view the changes, it seems to be hard-coding the current speed values in de dashboard config. I don't see why it should do this since it changes every minute.

To Reproduce edit dashboard and exit without changing anything and view the changelog. image

Expected behavior I should exit without a save prompt because there were no changes.

VERSIONS:

Additional context Using Zabbix as the source for the data.

knightss27 commented 1 year ago

Thanks for pointing this out. It was something I had seen before but hadn't spent the time getting to the bottom of. I think that I've fixed it, but need to do some more testing to ensure I haven't accidentally broken something else. I'll close this issue when the update to fix this is released.

Long story short, since I originally wrote this part of the program, Grafana has added better state handling for the panel so some tricks I had implemented to reduce calls to redraw were no longer useful (and this "state written to dashboard JSON" was an outcome of that).

knightss27 commented 1 year ago

Alright, the new version is out on Grafana (it's v0.4.2). You might have to save your dashboard once (after updating the plugin) for this to fully take effect? But from my testing on the released version I can now update the dashboard to see the new values and leaving or trying to save brings up no new changes.

EYEVO commented 1 year ago

Seems to work now, thanks!