search

knik0 / faac

Freeware Advanced Audio Coder faac mirror
https://sourceforge.net/projects/faac/
Other
180 stars 60 forks source link

1.29.9.2: compatibility with old versions of gcc (< 4.8.0) #26

Closed zvezdochiot closed 5 years ago

zvezdochiot commented 5 years ago

compatibility with old versions of gcc (< 4.8.0)

fabiangreffrath commented 5 years ago

Instead of messing around with the compiler version, you could add a check to configure.ac: https://patchwork.freedesktop.org/patch/181224/

zvezdochiot commented 5 years ago

Can. But if you need to compile it on gcc 4.7.2?

fabiangreffrath commented 5 years ago

The configure check checks the availability of the function, not the compiler version.

What if you compile with any version of clang?

zvezdochiot commented 5 years ago

Good question. Honestly I do not know.

fabiangreffrath commented 5 years ago

No reason to prematurely close this PR! I just asked you to replace the compiler version check with a feature check in the configure script.

zvezdochiot commented 5 years ago

The reason is. PR is very specific, sharpened by gcc. Solves one problem. And others do not create?