search

knik0 / faac

Freeware Advanced Audio Coder faac mirror
https://sourceforge.net/projects/faac/
Other
179 stars 60 forks source link

Time for a 1.30 release #32

Closed fabiangreffrath closed 4 years ago

fabiangreffrath commented 4 years ago

I'd like to tag the current state of the code as a formal release.

@zvezdochiot @vividos @FoxesChen You have contributed to the code lately. Is there anything missing in your opinion?

zvezdochiot commented 4 years ago

A small remark.

I did not have time to verify the mp4 container after corrections. Good correctness detectors are the MPD and Sony Walkman player. In previous versions, I had to use FFMPEG to fix the container. Or used MP4Box for containerization (aac -> m4a).

vividos commented 4 years ago

There is a compiler error when compiling with VS 2019. In input.c the uint8_t data type is used, but the necessary <stdint.h> include is missing. Otherwise it compiles without errors.

vividos commented 4 years ago

with the latest commit faac compiles now without errors.

fabiangreffrath commented 4 years ago

@zvezdochiot Any clue what was wrong with the mp4 containers created by faac?

zvezdochiot commented 4 years ago

@fabiangreffrath say:

Any clue...

MPD just does not see them. Sony Walkman plays only the first second. I didn’t look under the hood.

zvezdochiot commented 4 years ago

@fabiangreffrath see:

Any clue...

Tested the git version on MPD. Sees. Sony Walkman player is not at hand.

fabiangreffrath commented 4 years ago

Tested the git version on MPD. Sees.

I assume that's a good sign.

zvezdochiot commented 4 years ago

@fabiangreffrath say:

I assume that's a good sign.

To understand what's under the hood, you need to take faac 1.28 and use https://github.com/madsen/vbindiff to look at the differences. But it takes time, I do not have it. (At 1.28 there was definitely a “bad” m4a container.)

fabiangreffrath commented 4 years ago

I am not going to do this, either. If you say the mp4 files produced by current git are properly recognized then I am fine with that.

zvezdochiot commented 4 years ago

"Comment and close":

https://github.com/knik0/faac/releases/tag/1_30