[1]
The PR knik0#39 converted line endings from LF to CR+LF. This fixes it.
[2]
knik0#39 made a change to Debug x64 only. I applied it also to the other conditions.
But this change caused a conflict. Both faac.vcxproj and libfaac.vcxproj wrote the same program database (PDB) file <project/msvc/bin/(Debug|Release)/faac.pdb>. The PDB from libfaac.vcxproj was overwritten with that from faac.vcxproj.
To avoid this, I used project name instead of target name to let libfaac.vcxproj write libfaac.pdb.
[3]
Since knik0#46, we don't need to add _USE_MATH_DEFINES to MSVC projects.
fabiangreffrath
commented
1 year ago
[1] The PR knik0#39 converted line endings from LF to CR+LF. This fixes it.
[2]
knik0#39 made a change to Debug x64 only. I applied it also to the other conditions. But this change caused a conflict. Both faac.vcxproj and libfaac.vcxproj wrote the same program database (PDB) file <project/msvc/bin/(Debug|Release)/faac.pdb>. The PDB from libfaac.vcxproj was overwritten with that from faac.vcxproj. To avoid this, I used project name instead of target name to let libfaac.vcxproj write libfaac.pdb.
[3] Since knik0#46, we don't need to add _USE_MATH_DEFINES to MSVC projects.