search

knik0 / faac

Freeware Advanced Audio Coder faac mirror
https://sourceforge.net/projects/faac/
Other
179 stars 60 forks source link

Dropping allowMidside breaks nearly all library consumers #8

Closed ephemeralriggs closed 6 years ago

ephemeralriggs commented 6 years ago

In commit 12d7414f7ece191783e54d92beb46e0e182202f6 the struct member allowMidside is dropped from faacEncConfiguration.

This breaks the build on virtually every consumer of libfaac. Due to the history of AAC in open source projects, many of those consumers are not frequently updated anymore. For example, in FreeBSD we keep a (no longer maintained) package of ffmpeg before 1.0 around in order to support other infrequently maintained packages. This old ffmpeg package (and quite a few more, obviously) expect allowMidside.

Would it be possible to stay backward compatible for a certain grace period and keep the struct member allowMidside for now? This would allow the community to come up with the necessary workarounds in a release-friendly manner.

knik0 commented 6 years ago

A trivial patch to all those packages: just don't set allowMidside and you're OK.

ephemeralriggs commented 6 years ago

Thanks! Easy enough :-)

ilovezfs commented 6 years ago

@riggs- good news: backwards compatibility was restored as of 1.29.9.2 thanks to @enzo1982 and @knik0