search

knik0 / faad2

Freeware Advanced Audio (AAC) Decoder faad2 mirror
https://sourceforge.net/projects/faac/
Other
173 stars 77 forks source link

--without-drm stopped working with 2.8 #15

Closed dgilman closed 4 years ago

dgilman commented 6 years ago

If you ./configure --without-drm in 2.8.x you will still get a libfaad_drm.2 shared object. The config.h is properly created with DRM undefied, there is something that is putting -DDRM into the CFLAGS in the makefile and that is forcing DRM to be defined at compile time.

fabiangreffrath commented 6 years ago

It doesn't build either one variant or the other anymore, but always builds both at once. I cannot see what's wrong with this.

neheb commented 4 years ago

This is the problem: https://github.com/knik0/faad2/commit/881b5e263f25a8a8b714e83407fc2c9dab407e40

I will submit a patch partially fixing this.

fabiangreffrath commented 4 years ago

https://github.com/knik0/faad2/commit/74e949f962be802ddbd981b3a7f043d5ca442f11