search

knime-ip / knip-ilastik

KNIP / Ilastik Integration (BETA)
5 stars 1 forks source link

Xyzc override rebased #15

Closed maierl closed 7 years ago

maierl commented 7 years ago

same as #13 but mergeable.

ilastik gave me a XYT .tiff instead of a XYZC .tiff, so I implemented an override within knime.

missing input cells should be handled correctly by readResultImages().

dietzc commented 7 years ago

do we need the two "merge" commits at the beginning and the one inbetween?

maierl commented 7 years ago

not sure if they were already included somewhere else, but the result looks fine and the individual changes of the merge commits, too.

maierl commented 7 years ago

should we change all logger calls to the new LOGGER and make it static?

dietzc commented 7 years ago

not sure if they were already included somewhere else, but the result looks fine and the individual changes of the merge commits, too.

It's just that they are unnecessary and somehow pollute the history. Let's try to avoid them in the future. Anyway, I will merge! Thanks!