search

knime-ip / knip-scijava

KNIP - SciJava Commands Plugin
2 stars 3 forks source link

Ensure log messages of Commands are entered into the KNIME log. #28

Closed gab1one closed 8 years ago

gab1one commented 8 years ago
Problem:

Some log and error messages of Commands are only visible in the dbg stdout, instead of the KNIME log. The cause seems to be that these Commands log via a LogService:

@Parameter
private LogService log;
Idea: KNIMELogService

Add the KNIMELogService with very high priority that pushes the log messages into the KNIME log.

There is already a KNIPLogService in org.knime.knip.core it could be refactored and moved to knip-scijava.

dietzc commented 8 years ago

absolutely. However, we should add the possibility to the KNIMELogService, that KNIME nodes can set their individual LogLevel and also somehow add information which node / class published a log message. Basically, we should mimic some of the behaviour of the the NodeLogger of KNIME in the KNIMELogService while still implementing LogService.