search

knime-ip / knip-scijava

KNIP - SciJava Commands Plugin
2 stars 3 forks source link

Configure() method should fail when the inputspec is not compatible, related with #70 #39

Open gab1one opened 8 years ago

gab1one commented 8 years ago

If a generated node is configured, e.g. when connected to another node, the configuration must fail if the inputspec is not compatible. This could be the case if no column of a required type is available.

Squareys commented 8 years ago

@dietzc Since in #49 we now require the Hook and have the column selection widget, which throws "NotConfigurableException" if no matching input column is available, this will be done with that, too, right?

Squareys commented 8 years ago

@gab1one Ok if I remove the in progress label?

dietzc commented 8 years ago

I think you are right @Squareys. Can you double-check and close the issue? However, the exception should be treated gracefully.

Squareys commented 8 years ago

treated gracefully

The graceful part is usually already handled in KNIME (it should show the invalid settings dialog), but maybe we mean different things? Do you mean still being able to save the settings (just display a warning), even though not actually valid?

dietzc commented 8 years ago

We want default KNIME behaviour: Node is red, but can be configured (or so)?

Squareys commented 8 years ago

We want default KNIME behaviour: Node is red, but can be configured (or so)?

Wouldn't default behaviour be not to allow configuring invalid settings? And if no auto-setting for the input column selection for example could be found (new node with no node connected at input set), then it is red?

dietzc commented 8 years ago

Wouldn't default behaviour be not to allow configuring invalid settings? And if no auto-setting for the input column selection for example could be found (new node with no node connected at input set), then it is red?

Exactly.