search

knime-ip / knip-scijava

KNIP - SciJava Commands Plugin
2 stars 3 forks source link

Adapter Refactor - Use Converter Framework #5

Closed Squareys closed 8 years ago

Squareys commented 8 years ago

Hello hello :)

I finally finished the adapter-refactor to Scijava Converters. This PR also adds basic KNIME unit test projects, which will definitely come in handy for some of the more complex Services aswell.

I still need to make sure that the current API works (for knip-scripting), until then, whoever is bored may have a look at this or review or whatever.

This is not ready for merge quite yet!

Greetings, Squareys

Squareys commented 8 years ago

@dietzc Btw: Does any other project use the Settings/Widget/Adapter Framework which might break because of this?

@tibuch @seebacherd Do you use any of these Services in the FeatureNode? InputAdapterService, OutputAdapterService, KnimeWidgetService, NodeSettingsService, NodeSettingsHarvester?

dietzc commented 8 years ago

@Squareys I don't think any project besides scripting already uses this functionality at all.

Squareys commented 8 years ago

Alright, great, using the converters might possibly even simply code in knip-scripting, which is pretty neat.

@dietzc If there are no other projects, I believe this can be merged without further consideration.