search

knime-ip / knip-scijava

KNIP - SciJava Commands Plugin
2 stars 3 forks source link

Fix StringIndexOutOfBoundsException issue on class load. #60

Closed uphy closed 6 years ago

uphy commented 7 years ago

Added negative index check for String#indexOf(String).

We want to use JavaFX UI in KNIME node extension. For that, we need to specify '-Dorg.osgi.framework.bundle.parent=ext' in knime.ini, However, when we specify that, the StringIndexOutOfBoundsException occurs because the url of non-osgi bundle resource doesn't contains bundle id.

Could you merge this simple check?

dietzc commented 7 years ago

@uphy sorry, I missed this PR. I'll review it next week!

uphy commented 6 years ago

any updates?

gab1one commented 6 years ago

On the master branch now, thank you :)

uphy commented 6 years ago

thank you!