knime-ip / knip

KNIME Image Processing Extension
https://www.knime.com/community/image-processing
50 stars 10 forks source link

New TableCellViewer: Rewrite #127

Open dietzc opened 9 years ago

dietzc commented 9 years ago

Issue for the new gallery based implementation of the TableCellViewer. See https://github.com/knime-ip/knip/tree/combinedImgViewer

Open Points:

thanks @AndreasBurger, it already looks amazing.

maierl commented 9 years ago

the currently selected column (or cell) should be highlighted better than with the old viewer. especially tables containing mostly black pictures are problematic.

dietzc commented 9 years ago

@AndreasBurger can you take care of this?

AndreasBurger commented 9 years ago

I've modified the TableCellRenderer to highlight the currently selected cell (see attached image). Using this approach, however, enables this behaviour in all dialogs - which I think is actually nice.

@dietzc Any reservations?

screenshot

dietzc commented 9 years ago

@dietzc Any reservations?

Somehow this indicates that the hiliting mechansim of KNIME is enabled, which is not the case. Maybe we can use another mechansim/color to hilite the selected cell (red overlay or so?).

maierl commented 9 years ago

The hiliting vs selection could be confusing, but using a border in general seems fine to me. A colored overlay on a color image will cause problems.

maierl commented 8 years ago

i'd prefer to open the full image only after double-clicks, so i could select images without opening them right away.

dietzc commented 8 years ago

needs cleanup.