search

knime / knimepy

Other
44 stars 15 forks source link

Failing test: test_container_1_input_1_output_mismatched_input_datatypes #10

Closed applio closed 4 years ago

applio commented 5 years ago

The test_container_1_input_1_output_mismatched_input_datatypes unit test passes against KNIME 3.6 but is failing against KNIME 3.7.

In KNIME 3.7, the behavior of the json parsers changed to throw errors if certain unexpected inputs are provided whereas in earlier versions it silently swallowed these issues and generically placed data into a String.

This test should be updated to expect the behavior of KNIME 3.7 while still passing when run against KNIME 3.6.

applio commented 4 years ago

No reasonable path seems to exist to quickly determine that we are running against KNIME 3.6 (or some other older version) which makes it difficult or impractical to alter behavior exclusively for KNIME 3.6. As such, we can skip making this test work on the one outdated version of KNIME where it fails.