search

knime / knimepy

Other
44 stars 15 forks source link

Adjust test to expect KNIME v3.7+ behavior in its json parser. #13

Closed applio closed 4 years ago

applio commented 5 years ago

Per issue #10 this patch adjusts the test, which was originally created to document KNIME v3.6 behavior, to henceforth expect KNIME v3.7 behavior in its Container Input (Table) node's json parser.

To be clear, this does not break any support for KNIME v3.6 but this test will no longer pass with versions of KNIME older than v3.7.

applio commented 4 years ago

The two commits I just pushed are to implement the suggestion from @MarcelWiedenmann to make the unit test around mismatched JSON types more robust by verifying that the exception we trap is not the result of an accidental locked workflow conflict.

The test is a "negative test" in the sense that it tries to verify that a locked workflow conflict did not occur. Instead a "positive test" that we did indeed trigger a problem in the JSON parser employed by KNIME might be preferred but there does not appear to be a robust way at this time to verify this through the knime log or stderr.