search

knime / knimepy

Other
44 stars 15 forks source link

Add encoding argument to open #30

Open k-ujihara opened 3 years ago

k-ujihara commented 3 years ago

settings.xml can contain non-ASCII characters such as" ⇒ ", but it cannot be read by systems whose default encoding is not UTF-8.

This can be resolved by adding encoding ="utf_8" argument to open function. Character encoding is embedded in XML, so following it is more desirable .

https://github.com/knime/knimepy/blob/fc10f3840f80f5625d8c10bedceeda5476fc5096/knime.py#L71

Currently below workaround is required.

set PYTHONUTF8=1
unnumsykar commented 2 years ago

I am new to open source, how can I contribute to this issue ?