knime / knimepy

Other
44 stars 15 forks source link

Add proper XML encoding handler #34

Open mhxion opened 1 year ago

mhxion commented 1 year ago

Fix #30

Add an inner function that retrieves XML encoding information from XML declaration line (if exists) and pass it to open() so it decodes the XML properly.

Local workflow execution tests:

Screenshot 2023-05-20 at 3 36 35 PM
mhxion commented 1 year ago

I also applied for a working student position at Knime with this PR, if it makes any difference.

mhxion commented 1 year ago

Squashed the last commits (as the last commit was just cleaning up syntax formatting) as suggested by @steffen-fissler. Although this required a force-push, an alternative would've been using the GitHub squash feature before accepting the pull request, I think in this case it doesn't affect the public repository.