search

knipknap / better-tool-library

A FreeCAD addon and command line tool for managing tool libraries
MIT License
20 stars 10 forks source link

Main screen hard to read when using Dark Theme #16

Closed Connor9220 closed 1 month ago

Connor9220 commented 10 months ago

Using ProDarkThemePack -- OpenDark looks a bit better, but the gray color still doesn't show up very well.

Screenshot from 2024-01-16 01-48-35

Sub pages look a bit better

Screenshot from 2024-01-16 01-53-37

All end mill images could use more contrast or something.

knipknap commented 10 months ago

I added some logic to improve contrast in dark themes, but it seems that the ProDark theme is simply broken and overwrites this. In other words, it styles things that just shouldn't be styled - even though I explicitly assigned the text color to each of the labels, the color is still not used when that theme is active.

It looks like this cannot be fixed in BTL - or if anyone knows how please provide a patch.

Connor9220 commented 10 months ago

Here's what the main screen looks like in OpenDark

Screenshot from 2024-01-16 17-04-49

knipknap commented 1 month ago

I now understand theming of FreeCAD better than when the issue was opened: This is actually not something BTL can or should control.

In other words, such bugs need to be reported to the theme author instead - I cannot fix it.