knipknap / better-tool-library

A FreeCAD addon and command line tool for managing tool libraries
MIT License
22 stars 11 forks source link

Changes to fusionserializer.py #23

Closed ShamanTcler closed 9 months ago

ShamanTcler commented 10 months ago

around line 140 change: (case sensitive)

       tool_type = toolitem["type"]

to tool_type = toolitem["type"].lower()

later the code looks like:

             if tool_type in ("ball end mill", "flat end mill", "reamer", "boring bar", "counter bore", "lollipop mill"):
                pass
            if tool_type == "bull nose end mill":
                tool.shape.set_param(
                    "TorusRadius",
                    DistanceParam(name="TorusRadius", unit=lunit, v=geom["RE"]),
                )

I believe it should look like:

            if tool_type in ("ball end mill", "flat end mill", "reamer", "boring bar", "counter bore", "lollipop mill"):
                pass
  Change to elif --->          **elif** tool_type == "bull nose end mill":
                tool.shape.set_param(
                    "TorusRadius",
                    DistanceParam(name="TorusRadius", unit=lunit, v=geom["RE"]),
                )
knipknap commented 9 months ago

Thanks, I pushed these changes.