knipknap / exscript

A Python module making Telnet and SSH easy
MIT License
367 stars 136 forks source link

fix: update regex for newer junos prompt #211

Open yoleri opened 4 years ago

yoleri commented 4 years ago

[ error ]

    Exception in thread Thread-1:
    Traceback (most recent call last):
    File "/usr/local/lib/python3.5/dist-packages/Exscript/protocols/protocol.py", line 769, in _app_authenticate
    index, match = self._waitfor(prompt_list)
    File "/usr/local/lib/python3.5/dist-packages/Exscript/protocols/protocol.py", line 986, in _waitfor
    result = self._domatch(re_list, False)
    File "/usr/local/lib/python3.5/dist-packages/Exscript/protocols/ssh2.py", line 422, in _domatch
    if not self._fill_buffer():
    File "/usr/local/lib/python3.5/dist-packages/Exscript/protocols/ssh2.py", line 393, in _fill_buffer
    raise TimeoutException(error)
    Exscript.protocols.exception.TimeoutException: Timeout while waiting for response from device

    During handling of the above exception, another exception occurred:

    Traceback (most recent call last):
    File "/usr/lib/python3.5/threading.py", line 914, in _bootstrap_inner
    self.run()
    File "/usr/lib/python3.5/threading.py", line 862, in run
    self._target(*self._args, **self._kwargs)
    File "", line 74, in 
    conn.login(account)
    File "/usr/local/lib/python3.5/dist-packages/Exscript/protocols/protocol.py", line 675, in login
    self.authenticate(account, flush=False)
    File "/usr/local/lib/python3.5/dist-packages/Exscript/protocols/protocol.py", line 701, in authenticate
    self.app_authenticate(app_account, flush=flush)
    File "/usr/local/lib/python3.5/dist-packages/Exscript/protocols/protocol.py", line 870, in app_authenticate
    self._app_authenticate(account, password, flush, bailout)
    File "/usr/local/lib/python3.5/dist-packages/Exscript/protocols/protocol.py", line 774, in _app_authenticate
    raise TimeoutException(msg)
    Exscript.protocols.exception.TimeoutException: Buffer: ''

[ cause ] The shell prompt has changed in newer JunOS versions

[ prompt ] 14.1R7.4: root@dev1% 18.4R3.3: root@dev1:~ #

[ fix ] Add support for new prompt

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.01%) to 76.816% when pulling 55caa9020a59d9c89aedc966b7bf53abc08245e0 on yoleri:patch-1 into f9a48a29aabf3fcfa0a1e2eb980af4b41e616617 on knipknap:master.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 76.802% when pulling 5a9539fd2c7d7197f4e3cd0f2ff9315fcc42591a on yoleri:patch-1 into f9a48a29aabf3fcfa0a1e2eb980af4b41e616617 on knipknap:master.