search

knit-pk / homepage-nuxtjs

Here we're trying to ship the front of homepage of KNIT
MIT License
13 stars 0 forks source link

Add baners for lists #128

Closed FieryCod closed 6 years ago

FieryCod commented 6 years ago

Since @kamil-stasiak did mistake by merging the PR I was forced to revert the previous PR. This PR is revert of revert.

PS: Changing permissions to allow merge button for only @zrebcu411 @k911 and me. Merge should be applied only after 3 approvals and no errors on codeclimate & travis.

k911 commented 6 years ago

PS. I'm afraid that soon we'll have store paths looking like this: view/categories/currentCategoryCodeOnXxxPage. So I'd reconsider extracting context of page to something like context/articlesList/categoryCode.

FieryCod commented 6 years ago

@k911 I refactored a little bit. I don't think it's going to happen. If you don't mind I would keep it like it is. Of course, if there would be such a problem then will be the first one who'll do the refactor ;P

FieryCod commented 6 years ago

@k911 Thank you :)

codeclimate[bot] commented 6 years ago

Code Climate has analyzed commit ae76d320 and detected 0 issues on this pull request.

View more on Code Climate.