search

knit-pk / homepage-nuxtjs

Here we're trying to ship the front of homepage of KNIT
MIT License
13 stars 0 forks source link

New style of cards on all categories list #135

Closed kgogola closed 6 years ago

FieryCod commented 6 years ago

@kgogola Please always give a link to the task (if there is of course).

Firstly as I can see the task mentions the artykuly/wszystkie and implies that there was a problem with the styling. You did change on all pages where article cards were used.

Your change: image

Current: image

I can see the difference! What I recommend is to not move html (template) code and only operate on styles.

Also, the card which is on the layout is slightly different than the one you're proposing check the artykuly/wszystkie

FieryCod commented 6 years ago

@zrebcu411 @k911 Want to add something?

FieryCod commented 6 years ago

Please always add correct labels :)

codeclimate[bot] commented 6 years ago

Code Climate has analyzed commit d5ea51a0 and detected 0 issues on this pull request.

View more on Code Climate.

FieryCod commented 6 years ago

@kgogola Any progress?