search

knit-pk / homepage-nuxtjs

Here we're trying to ship the front of homepage of KNIT
MIT License
13 stars 0 forks source link

Move the project to /src folder #149

Closed FieryCod closed 6 years ago

FieryCod commented 6 years ago

I think it's a nice convention to keep the source files in /src folder. I'm having trouble with managing the deploy and docker folders.

@k911 could you please take a look? I will highly appreciate that!

🎉 🎉 ❤️ 🎉 🎉

k911 commented 6 years ago

Nice one, I'll review soon! :+1: In meantime I think in "scope" part of commitizen/commit message we should not use verbs (maybe: project-structure or only struct would be better).

You have also some conflics, so I think you need to rebase first.

k911 commented 6 years ago

To fix travis docker builds you need to rename deploy to deployment in the travis.yml and in deploy/* scripts, but I don't think that renaming it is necessary, because it is a shorter name (faster to type)

k911 commented 6 years ago

@FieryCod It seems you've merged old yarn.lock could you please remove it from first commit, and yarn upgrade in next commit (or PR)?

k911 commented 6 years ago
  1. In commit: https://github.com/knit-pk/homepage-nuxtjs/pull/149/commits/9e6c11b9d16fb92493cb7dba8a515d2a4eadfb03 You still have yarn.lock
  2. Travis failure seems legit
FieryCod commented 6 years ago

@k911 Could please check one more time? I think that I am ready to merge this :)

FieryCod commented 6 years ago

@k911 No problem. Thank you very much for all your comments. :)

codeclimate[bot] commented 6 years ago

Code Climate has analyzed commit cd5913ef and detected 22 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 11
Style 1
Clarity 6
Bug Risk 4

View more on Code Climate.

k911 commented 6 years ago

Nice, really good job! :+1: