search

knit-pk / homepage-nuxtjs

Here we're trying to ship the front of homepage of KNIT
MIT License
13 stars 0 forks source link

Optimize FixedTop scrolling #82

Closed k911 closed 6 years ago

FieryCod commented 6 years ago

@k911 As I said it's not a problem of fixedTop. It's a problem of v-prevent-scroll.

Here is the prove:

When job-offers-widget is rendered then the warning occurs: image

When job-offers-widget is not rendered then warning does not occur: image

To conclude: There is no problem with fixedTop. There is a problem with job-offers-widget which uses v-prevent-parent-scroll. Check my comment above. Your change does only this that fixedTop flickers.

Please close the PR and create a new one which does not change fixedTop but v-prevent-parent-scroll

k911 commented 6 years ago

@FieryCod I know, but this one could be optimized as well. WIP = Work in progress. About v-prevent-parent-scroll directive I've tried and failed, because passive event cannot use e.preventDefault() because it is passive.. :) so for above warning I'm afraid there's no solution.

FieryCod commented 6 years ago

84 Please check it. If the issue is connected with passive events please update only it and provide some sort of prove that it's really helping.

FieryCod commented 6 years ago

Taking the work in behalf of @k911 .