search

knittl / idea-jmh-plugin

Plugin for Jetbrains Intellij IDEA to make benchmarking with JMH easier.
https://plugins.jetbrains.com/plugin/13868-jmhack
MIT License
6 stars 1 forks source link

Merge JMHack with original JMH plugin #2

Open stokito opened 4 years ago

stokito commented 4 years ago

HI @knittl and thank you for maintaining a fork of JMH plugin. I asked its author to become a maintainer and he gave me a permission to accept PRs and perform release. I merged your fork into original plugin and today it was released. So now to avoid users confusion could you request removing of JMHack? Off course unless you have plans to continue its development. On plugins page there is a button to request removal but unfortunately there is no such possibility to set a plugin for replacement. You may make the original JMH plugin as dependency and make a dummy release so users on update will install the original JMH plugin. If you have any ideas please feel free to create issues or pull requests. Thank you for your contribution.

knittl commented 4 years ago

Hi @stokito,

thanks for the info. It is great that the JMH plugin is actively maintained again :) Thanks for merging my changes upstream.

I will have to check what the best option would be going forward with the fork and how to proceed with phasing it out. The original/upstream "JMH plugin" is mentioned in the README file and on the plugin page, so users will be able to find the upstream.

Once I have tought about this in detail, I will let you know. Thanks again!

stokito commented 4 years ago

the problem is that when user searches for "JMH" in marketplace it sees JMHack which has even better rating :) But currently it has only 900 donwloads which is not so many. Let's just remove the plugin and users that have a JMH run configuration will be prompted by Idea to install original JMH