search

knjk04 / Bookshelf

Android book wishlist app
GNU General Public License v3.0
1 stars 1 forks source link

Http -> https could be done erroneously #19

Closed knjk04 closed 5 years ago

knjk04 commented 5 years ago

The changeHttpToHttps() method in Book.java could be even if the http appears somewhere other than the start of the String. Change the regex so that the string URL is only changed if "http" appears at the start of the String.

knjk04 commented 5 years ago

Fixed with commit https://github.com/knjk04/Bookshelf/commit/ee86c7e22abf62ba9f9ca59bbb483a9089689f07 by using replaceFirst() instead of replace()