search

knksmith57 / hexo-renderer-sass

Sass renderer plugin for Hexo
47 stars 45 forks source link

fix: add engine requirements for node >= 0.10 #27

Closed knksmith57 closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 037e8b1b743afc0f9b9d381b2e2b16963ceb5f45 on add-engine-requirements into 0833a6ff41501af935564e282044c1371b4853a4 on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 037e8b1b743afc0f9b9d381b2e2b16963ceb5f45 on add-engine-requirements into 0833a6ff41501af935564e282044c1371b4853a4 on master.

knksmith57 commented 7 years ago

OK, I was thinking we'd land this before #25. Probably can just close this out without landing then, @JLHwung?

JLHwung commented 7 years ago

@knksmith57 Actually I think this PR could be landed. I have pushed a branch 0.2.x, could you cherry-pick to that branch and release 0.2.1? Then we can move forward to 0.3.

knksmith57 commented 7 years ago

@JLHwung alrighty, changed the target branch to 0.2.x, rebased clean. The build is failing because there's no config on the 0.2.x branch, but I think we're good to go.

Want me to cut the 0.2.1 release now?

JLHwung commented 7 years ago

@knksmith57 Thank you for rebasing. Looks good to me. 😄