knksmith57 / hexo-renderer-sass

Sass renderer plugin for Hexo
47 stars 45 forks source link

Migrate to GitHub Actions and drop Node < 14 support #52

Closed JLHwung closed 1 year ago

JLHwung commented 1 year ago

Closes #49

The new GitHub actions runs lint & coverage report on the latest Node, then runs only test on other Node versions.

JLHwung commented 1 year ago

@knksmith57 Hey there. The codecov upload actions requires secrets.CODECOV_TOKEN to be set. Can you generate one and put it there? For reference you can see

https://docs.codecov.com/docs/quick-start and https://docs.github.com/en/actions/security-guides/encrypted-secrets

Thank you.

knksmith57 commented 1 year ago

Heya @JLHwung, I followed that guide and used the GitHub App installation method that they recommend instead of the environment variable approach—it's installed on this repo now and I verified that Codecov has it registered now and is showing "no data" image

If that doesn't work, please let me know and I can also generate a secret for it! Thank you!

JLHwung commented 1 year ago

@knksmith57 It works now, thanks! https://github.com/knksmith57/hexo-renderer-sass/actions/runs/5280453565/jobs/9553535964#step:7:35

knksmith57 commented 1 year ago

@knksmith57 It works now, thanks! https://github.com/knksmith57/hexo-renderer-sass/actions/runs/5280453565/jobs/9553535964#step:7:35

heck yeah, nice!! 😄 🎉

Thanks so much for getting this project back in shape and wiring all that up!