Fix issue references in PR messages

knl / niv-updater-action

A GitHub Action that creates meaningful pull requests with updates to your niv-managed dependencies, so you don't have to do menial chores.

BSD 3-Clause "New" or "Revised" License

29 stars 11 forks source link

Fix issue references in PR messages #8

Closed nomeata closed 4 years ago

nomeata commented 4 years ago

The PR message includes the log of the upstream repo, which is great! But if the upstream repo references PRs or issues (#123), then Github will render them pointing to the wrong repo.

I suggest to wrap the commit message in ` (easy solution). Or change the output and prepend the issue with the repo (knl/niv-updater-action#3) so that Github renders them correctly.

(Probably hard to to completely correct.)

nomeata commented 4 years ago

(I guess ideally this would be functionality built into niv, and not this action, so that I can create nice commit messages even when using niv upgrade locally.)

knl commented 4 years ago

Thanks for reporting the issue @nomeata ! Will see what I can do about it.