search

knmnyn / ParsCit

An open-source CRF Reference String Parsing Package
http://wing.comp.nus.edu.sg/parsCit
GNU Lesser General Public License v3.0
155 stars 47 forks source link

Employ CRFPP as a submodule #27

Closed lgalke closed 7 years ago

lgalke commented 7 years ago

The shipped version of CRFPP does not compile on my machine anymore. Fixing some missing imports did help at some point (as in the Dockerfile). However, today I could not get it to compile on my (Kali Linux 2017.2) machine once again. Thus, I successfully tried to employ the most recent version of CRFPP as a submodule. The PR also offers a Makefile for a clean install of crf_test, crf_learn from the CRFPP submodule source. The dockerfile is not yet upgraded.

Please view this PR as an inspiring suggestion. Building the most recent version of CRFPP is less troublesome than the version shipped with ParsCit.

cmkumar87 commented 7 years ago

Thanks! We are aware of problems with the old crfpp library we ship with ParsCit. We appreciate your effort to fix the install. We will test the install with the new Makefile and merge. Cheers! Muthu

lgalke commented 7 years ago

Great to see instantaneous feedback! :+1: Since we want to continue developing additional features in the master branch of the fork, I will issue another pull-request from a dedicated branch (and close the present PR).