knocean / knode

Knowledge Development Environment
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Clean up routing table #49

Closed inaimathi closed 7 years ago

inaimathi commented 7 years ago

Right now, we're using base compojure, which creates a central routing table structure. This has already led to minor merge conflicts among branches. Ideally, we'd switch to a framework that allowed decentralized route declaration, or possibly rolling our own. In either case, we'd want it to expose a ring-compatible interface so that we could use all our existing middlewares.

jamesaoverton commented 7 years ago

Good idea. Can you please assess https://github.com/juxt/bidi for this?

inaimathi commented 7 years ago

First ground broken at https://github.com/knocean/knode/pull/51. Just starting to experiment with bidi (which looks like it'll do it for what we want). Still a bunch todo though:

Also, not entirely sure if the atom-wrapped handler table/routes structure is a good idea or not. On the one hand, it'll make it a lot easier to do incremental development. On the other, we'll incur an extra atom read for each request at runtime.

jamesaoverton commented 7 years ago

There's more cleaning up to do, but let's count this as closed by 951c4a1d536f1439170acebc936b4d7d3396656d.