search

knocklabs / javascript

Official JavaScript packages for interacting with Knock
https://knock.app/
MIT License
10 stars 2 forks source link

fix: render issues in next 14 with react 18 strict mode #144

Closed cjbell closed 1 month ago

cjbell commented 1 month ago

Destroying the store unbinds listeners, which breaks our workaround for handling double renders in React strict mode. There's definitely something deeper going on here, but I cannot for the life of me figure it out.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
javascript-slack-connect-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 8:17pm
javascript-slack-kit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 8:17pm
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 4205e379195dac18ca0de099fb4eeddb98f91fbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages | Name | Type | | ------------------------------- | ----- | | @knocklabs/client | Patch | | client-example | Patch | | @knocklabs/react-core | Patch | | @knocklabs/react-native | Patch | | @knocklabs/react | Patch | | @knocklabs/react-native-example | Patch | | nextjs-example | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR