fix: remove event stop propogation from outside click hook

knocklabs / javascript

Official JavaScript packages for interacting with Knock

https://knock.app/

MIT License

10 stars 2 forks source link

fix: remove event stop propogation from outside click hook #152

Closed kylemcd closed 1 month ago

kylemcd commented 1 month ago

Description

A customer was experiencing an issue where when the notification feed popover was open, clicking a link outside of the popover would cause the page to hard refresh when using react-router-dom. Removing event.stopPropogation() from the useComponentVisible hook fixed this issue.

Tasks

KNO-6065

linear[bot] commented 1 month ago

KNO-6065 [JS SDK] Investigate event propagation issue with React popover

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
javascript-slack-connect-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 29, 2024 3:30pm
javascript-slack-kit-example	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 29, 2024 3:30pm

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 718e20a9d9594a35febb43d86c71c36a71396989

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | ---------------- | ----- | | @knocklabs/react | Patch | | nextjs-example | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR