knocklabs / javascript

Official JavaScript packages for interacting with Knock
https://knock.app/
MIT License
16 stars 3 forks source link

fix: convert trigger_data to string for in-app-messages api #267

Closed connorlindsey closed 1 month ago

connorlindsey commented 1 month ago

The API allows filtering by trigger_data, but expects it to be a string. An object is easier to work with and matches the feeds API, so we're going to just convert the object to a string before calling the API.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 87fca8812c9b6a15a5ca34cad2812a53fd985576

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

linear[bot] commented 1 month ago

KNO-7140 [SDK] Allow an object for trigger_data filter

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
in-app-messages-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 5:05pm
javascript-nextjs-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 5:05pm
javascript-slack-connect-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 5:05pm
javascript-slack-kit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 5:05pm
connorlindsey commented 1 month ago

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @connorlindsey and the rest of your teammates on Graphite Graphite