search

knocklabs / javascript

Official JavaScript packages for interacting with Knock
https://knock.app/
MIT License
11 stars 2 forks source link

fix: esm import issues #34

Closed connorlindsey closed 5 months ago

connorlindsey commented 5 months ago

When importing @knocklabs/react as esm, @knocklabs/react-core gets imported as common js where it should be esm. This updates the build to output .cjs files in the cjs build and .js in the esm build. Updates package.json to disambiguate the imports.

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: 624709d9d29cb3662af2e112bbd585dc94b92d6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kylemcd commented 5 months ago

Fixed with #48