knocklabs / javascript

Official JavaScript packages for interacting with Knock
https://knock.app/
MIT License
15 stars 3 forks source link

feat(kno-5138): enable popup window for slack auth flow #39

Closed meryldakin closed 8 months ago

meryldakin commented 8 months ago

Adds a pop up window for the slack auth flow rather than using a redirect for this. Relies on switchboard PR to return the window close html: https://github.com/knocklabs/switchboard/pull/1909

changeset-bot[bot] commented 8 months ago

⚠️ No Changeset found

Latest commit: 98c8430a3fd4521454e41d080c15d9245ce51947

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR