search

knocklabs / javascript

Official JavaScript packages for interacting with Knock
https://knock.app/
MIT License
15 stars 3 forks source link

fix: eslint-config devDeps not accessible, moving to deps #40

Closed kylemcd closed 8 months ago

kylemcd commented 8 months ago

When installing @knocklabs/eslint-config because the dependencies are set to devDependencies, they're not installed along with the config. This means each of those dependencies would need to be installed on their own.

This moves these devDependencies to dependencies to make install smoother.

changeset-bot[bot] commented 8 months ago

🦋 Changeset detected

Latest commit: 9c9248ff305db90972d0eff1c30d6e5fc90dac18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------ | ----- | | @knocklabs/eslint-config | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kylemcd commented 8 months ago

Looks good, but would run an install and push again in case there are conflicts with the lock file during deploy (I don't think it'll be a problem but just to be safe)

Yeah I regenerated the lock file but it was the same as before. No changes in git.