search

knocklabs / javascript

Official JavaScript packages for interacting with Knock
https://knock.app/
MIT License
10 stars 2 forks source link

feat(kno-5213): accept pagination params and split out connected channels from all slack channels hooks #53

Closed meryldakin closed 4 months ago

meryldakin commented 4 months ago

This PR allows us to paginate the slack channels query by introducing ReactQuery (note: the provider will be moved under the upcoming SlackProvider when it's available).

It also splits up our hooks for getting all of the available slack channels and only getting the connected channels because now that we have pagination, it makes it a lot easier for us to get and set that connected channel data when it's split from the whole list of slack channels.

There's other minor refactoring throughout, but a lot will still change when we introduce a shared context for the connected state of all the slack components, just to keep in mind as you're reviewing.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: f153e538734600697256492c4e63289104df0461

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

linear[bot] commented 4 months ago

KNO-5213 [react] update useSlackChannels hook to accept pagination params and store channels in local storage