search

knocklabs / javascript

Official JavaScript packages for interacting with Knock
https://knock.app/
MIT License
14 stars 3 forks source link

feat(kno-5241): if max channels reached, use text input to add channel #62

Closed meryldakin closed 7 months ago

meryldakin commented 7 months ago

This is a v1 text input for adding channels that I'd like to get in for us to play with and see what it needs. Basically we want to restrict using the combobox to only work if you have fewer than 1000 slack channels. if you have more than that, we'll intentionally degrade the experience to help with performance, which is where we have this input box come in.

It's very stupid, it just takes a text string and posts it to the setChannelData endpoint as an entry in channel data. It does not check if it belongs to a real slack channel (and it shouldn't this is out of scope). It does check if the channel id already exists in the connected channel ids. Once it's in, we can tweak the design. https://www.loom.com/share/7fda538f23fc4fd789bd837f2eb3cc44

linear[bot] commented 7 months ago

KNO-5241 [react] if max # channels reached, use text input for channel ID to set

changeset-bot[bot] commented 7 months ago

⚠️ No Changeset found

Latest commit: 40ef7da0d079e6458fed7314b46d07a8d7fa92cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR