knocklabs / javascript

Official JavaScript packages for interacting with Knock
https://knock.app/
MIT License
10 stars 2 forks source link

fix(kno-5254): hide inaccessible channels #69

Closed meryldakin closed 4 months ago

meryldakin commented 4 months ago

This handles the case where a user has a slack channel connected in Knock, but it isn't found in the list of Slack channels from the API, potentially because the bot doesn't have access to it (like a private channel it doesn't belong to). In this case it also wouldn't be able to post to the channel so it is accurate to show to the user that it is not connected.

It also updates some minor styling issues.

linear[bot] commented 4 months ago

KNO-5254 [react] handle when a private channel is not accessible by the bot but it's listed as a connection

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: e9665e0af1ff58344f69524a0dec9bdfb4d8ac64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
javascript-slack-connect-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 1:32pm