search

knocklabs / javascript

Official JavaScript packages for interacting with Knock
https://knock.app/
MIT License
10 stars 2 forks source link

fix: esm issues round 2 #74

Closed kylemcd closed 4 months ago

kylemcd commented 4 months ago

Customers were having issues with the latest builds of our packages. This was because they were trying to resolve .es.js files as modules which the JS compiler doesn't know how to interpret. The correct file extension for modules is .mjs so this PR modifies the vite config to accomplish this.

See this similar issue for more info: https://github.com/FortAwesome/Font-Awesome/issues/16439

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 280a85a1fe26c7b6ad4374b9e44ca105dce96429

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages | Name | Type | | ------------------------------- | ----- | | @knocklabs/react-core | Patch | | @knocklabs/client | Patch | | @knocklabs/react | Patch | | @knocklabs/react-native | Patch | | client-example | Patch | | nextjs-example | Patch | | @knocklabs/react-native-example | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
javascript-slack-connect-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 4:51pm
javascript-slack-kit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 4:51pm