search

knocklabs / javascript

Official JavaScript packages for interacting with Knock
https://knock.app/
MIT License
14 stars 3 forks source link

fix(kno-5338): qa pass 2 #77

Closed meryldakin closed 7 months ago

meryldakin commented 7 months ago

This PR handles Krisna's suggestions from the second QA pass https://www.notion.so/knockapp/SlackKit-QA-doc-a35f9536dc304aa0996c57c492a2cf4e?pvs=4#6e29797f0da4463f865512ce6966cbb0

linear[bot] commented 7 months ago

KNO-5338 QA pass 2

changeset-bot[bot] commented 7 months ago

⚠️ No Changeset found

Latest commit: 8bbbc849e7d3c2f6fe1e0be90360ce746c54c50b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
javascript-slack-connect-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 2:58pm
javascript-slack-kit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 2:58pm