knocklabs / javascript

Official JavaScript packages for interacting with Knock
https://knock.app/
MIT License
10 stars 2 forks source link

fix: update event format for client status updates #91

Closed JEverhart383 closed 4 months ago

JEverhart383 commented 4 months ago

This PR adds a second event broadcast on FeedItem status updates in the correct format, e.g. items.archived. It also add functionality to the client example to test this new event, which works as expected:

Screenshot 2024-03-01 at 2 51 58 PM Screenshot 2024-03-01 at 2 52 08 PM Screenshot 2024-03-01 at 3 01 40 PM

For some reason, the diff make the spacing look funky, but everything looks good if you look at the actual code.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 9f0339cccdf0a5661e4693d1f89c2b25b2fe43e6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
javascript-slack-connect-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 3:44pm
javascript-slack-kit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 3:44pm