knocklabs / javascript

Official JavaScript packages for interacting with Knock
https://knock.app/
MIT License
10 stars 2 forks source link

Move isRequestInFlight to client prop #93

Closed JEverhart383 closed 4 months ago

JEverhart383 commented 4 months ago

If it's useful for people to derive the state of the client using isRequestInFlight using the helper function I wanted to see what this would look like as a property of the feed store, so I worked up this PR to add that to the store and updated our internal usage.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: ec43e9a977e039df8cf97261091590478995c929

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
javascript-slack-connect-example ✅ Ready (Inspect) Visit Preview Mar 5, 2024 0:57am
javascript-slack-kit-example ✅ Ready (Inspect) Visit Preview Mar 5, 2024 0:57am